Page MenuHomePhabricator

Destroy notifications properly from `bin/remove destroy`
ClosedPublic

Authored by epriestley on May 18 2015, 7:28 PM.

Details

Summary

Fixes T8237. This table is unusual and doesn't have an id column, so delete() doesn't actually know how to delete records and fails.

Test Plan
  • Used bin/remove destroy to destroy an object with notifications, as per T8237.
  • Applied patch.
  • Used bin/remove destroy to get a clean delete.
  • Verified related notifications vanished from notification menu.

Diff Detail

Repository
rP Phabricator
Branch
destroynotif
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6075
Build 6095: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Destroy notifications properly from `bin/remove destroy`.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 7:29 PM
This revision was automatically updated to reflect the committed changes.