Page MenuHomePhabricator

Don't put a spacer line on the bottom of previews
ClosedPublic

Authored by epriestley on May 18 2015, 7:12 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Nov 13, 12:34 AM
Unknown Object (File)
Fri, Nov 8, 8:19 AM
Unknown Object (File)
Fri, Nov 8, 7:59 AM
Unknown Object (File)
Fri, Nov 8, 7:37 AM
Unknown Object (File)
Fri, Nov 8, 7:24 AM
Unknown Object (File)
Fri, Nov 8, 6:39 AM
Unknown Object (File)
Fri, Nov 8, 6:16 AM
Unknown Object (File)
Tue, Oct 29, 5:50 AM
Subscribers

Details

Summary

Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top.

Test Plan

Screen Shot 2015-05-18 at 12.10.27 PM.png (436×286 px, 22 KB)

Also looked at a couple other applications that use this and they looked correct.

Diff Detail

Repository
rP Phabricator
Branch
footer
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 6073
Build 6093: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Don't put a spacer line on the bottom of previews.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, chad, lpriestley.
chad edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 7:15 PM
This revision was automatically updated to reflect the committed changes.