Don't put a spacer line on the bottom of previews
ClosedPublic
Actions

Authored by epriestley on May 18 2015, 7:12 PM.

Details

Reviewers

btrahan
lpriestley
chad

Maniphest Tasks

T8182: Calendar preview has timeline lines going through it

Commits

Restricted Diffusion Commit
rP107d6db1e8f6: Don't put a spacer line on the bottom of previews

Summary

Fixes T8182. See screenshot in that task. We currently render a line to nowhere at the bottom of these previews. Instead, only render a line at the top.

Test Plan

Screen Shot 2015-05-18 at 12.10.27 PM.png (436×286 px, 22 KB)

Also looked at a couple other applications that use this and they looked correct.

Diff Detail

Repository

rP Phabricator

Branch

footer

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 6073
Build 6093: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 31042.May 18 2015, 7:12 PM

epriestley retitled this revision from to Don't put a spacer line on the bottom of previews.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, chad, lpriestley.

epriestley added a task: T8182: Calendar preview has timeline lines going through it.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 18 2015, 7:12 PM

chad accepted this revision.May 18 2015, 7:15 PM

chad edited edge metadata.

This revision is now accepted and ready to land.May 18 2015, 7:15 PM

Closed by commit rP107d6db1e8f6: Don't put a spacer line on the bottom of previews (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 7:18 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

18 lines

webroot/

rsrc/

js/

application/

transactions/

behavior-transaction-comment-form.js

3 lines

Diff 31042

View Options

resources/celerity/map.php