Page MenuHomePhabricator
Differential D12885

Remove phutil_exit()
ClosedPublic
Actions

Authored by epriestley on May 17 2015, 3:06 PM.
Tags
None
Referenced Files
F13813582: D12885.id30984.diff
Wed, Sep 18, 11:48 PM
F13813567: D12885.id31040.diff
Wed, Sep 18, 11:45 PM
Unknown Object (File)
Mon, Sep 16, 1:37 PM
Unknown Object (File)
Thu, Sep 12, 8:11 AM
Unknown Object (File)
Thu, Sep 12, 8:10 AM
Unknown Object (File)
Thu, Sep 12, 8:09 AM
Unknown Object (File)
Thu, Sep 12, 8:09 AM
Unknown Object (File)
Thu, Sep 5, 3:19 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8219: Remove phutil_exit()
Commits
rPHUb06c9860e868: Remove phutil_exit()
Summary

Fixes T8219. This mechanism is fraught with peril (confusing to developers and users) and not particularly valuable.

Test Plan

Grepped for everything I removed. Loaded some pages.

Diff Detail

Repository
rPHU libphutil
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30984.May 17 2015, 3:06 PM
epriestley retitled this revision from to Remove phutil_exit().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8219: Remove phutil_exit().
Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2015, 3:06 PM
btrahan accepted this revision.May 18 2015, 5:19 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 5:19 PM
Closed by commit rPHUb06c9860e868: Remove phutil_exit() (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
aphront/
writeguard/
16 lines
event/
events/
constant/
1 line
utils/
15 lines

Diff 31040

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
View Options

src/aphront/writeguard/event/AphrontWriteGuardExitEventListener.php

Loading...
View Options

src/events/constant/PhutilEventType.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility