Page MenuHomePhabricator
Differential D12885

Remove phutil_exit()
ClosedPublic
Actions

Authored by epriestley on May 17 2015, 3:06 PM.
Tags
None
Referenced Files
F15431688: D12885.id30984.diff
Mon, Mar 24, 1:58 PM
F15427504: D12885.diff
Sun, Mar 23, 2:43 PM
F15416645: D12885.id31040.diff
Thu, Mar 20, 12:45 PM
F15416563: D12885.id31040.diff
Thu, Mar 20, 12:05 PM
F15409243: D12885.id.diff
Wed, Mar 19, 3:46 AM
F15409184: D12885.id30984.diff
Wed, Mar 19, 3:34 AM
F15407642: D12885.diff
Tue, Mar 18, 6:44 PM
Unknown Object (File)
Tue, Feb 25, 3:24 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T8219: Remove phutil_exit()
Commits
rPHUb06c9860e868: Remove phutil_exit()
Summary

Fixes T8219. This mechanism is fraught with peril (confusing to developers and users) and not particularly valuable.

Test Plan

Grepped for everything I removed. Loaded some pages.

Diff Detail

Repository
rPHU libphutil
Branch
phutilexit
Lint
Lint Errors
SeverityLocationCodeMessage
Errorsrc/utils/utils.php:1074XHP45PHP Compatibility
Errorsrc/utils/utils.php:1074XHP45PHP Compatibility
Unit
Tests Passed
Build Status
Buildable 6041
Build 6061: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30984.May 17 2015, 3:06 PM
epriestley retitled this revision from to Remove phutil_exit().
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T8219: Remove phutil_exit().
Herald added a subscriber: epriestley. · View Herald TranscriptMay 17 2015, 3:06 PM
btrahan accepted this revision.May 18 2015, 5:19 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 18 2015, 5:19 PM
Closed by commit rPHUb06c9860e868: Remove phutil_exit() (authored by epriestley, committed by epriestley). · Explain WhyMay 18 2015, 5:29 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
3 lines
aphront/
writeguard/
16 lines
event/
events/
constant/
1 line
utils/
15 lines

Diff 30984

View Options

src/__phutil_library_map__.php

Loading...
View Options

src/aphront/writeguard/AphrontWriteGuard.php

Loading...
View Options

src/aphront/writeguard/event/AphrontWriteGuardExitEventListener.php

Loading...
View Options

src/events/constant/PhutilEventType.php

Loading...
View Options

src/utils/utils.php

Loading...
Phabricator · Built by Phacility