This adds minor functionality to PHUIHeaderView (icons, tags) that were previously on in ActionHeader. This allows us to remove the PHUIActionHeaderView outright in favor of just one Header class.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T8099: Mid-2015 Phabricator Redesign
- Commits
- Restricted Diffusion Commit
rPe5920618912a: [Redesign] Remove PHUIActionHeaderView
Tested each callsite, workboards, hovercards, conpherence.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- remove-action-header
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 6070 Build 6090: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
| src/applications/conpherence/controller/ConpherenceWidgetController.php | ||
|---|---|---|
| 71–86 | This section doesn't work, the JS fails and I'm not adept here enough to know what I need to tweak. The JS that fails is: var widget_header = JX.DOM.find(widget_pane, 'a', 'widgets-selector'); | |
| src/applications/conpherence/controller/ConpherenceWidgetController.php | ||
|---|---|---|
| 71–86 | Maybe just leave a comment and we can clean it up later before merging? Offhand, it might just be widgets-selector vs widgets_selector (hyphen vs underscore), as written. | |
| src/applications/conpherence/controller/ConpherenceWidgetController.php | ||
|---|---|---|
| 71–86 |  | |