Page MenuHomePhabricator

Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION
ClosedPublic

Authored by joshuaspence on May 17 2015, 11:13 PM.
Tags
None
Referenced Files
F14035980: D12892.id31007.diff
Sun, Nov 10, 8:09 AM
F14016943: D12892.id.diff
Mon, Nov 4, 11:46 AM
F14010101: D12892.id31006.diff
Thu, Oct 31, 4:56 AM
F13976991: D12892.diff
Fri, Oct 18, 4:38 PM
F13975071: D12892.id31007.diff
Fri, Oct 18, 8:34 AM
F13975064: D12892.diff
Fri, Oct 18, 8:33 AM
Unknown Object (File)
Oct 9 2024, 9:30 AM
Unknown Object (File)
Oct 1 2024, 2:54 AM
Subscribers

Details

Summary

The ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION linter rule was introduced in D12854, but fails for the following:

  • Interfaces which declare the __toString() method.
  • Classes which mark the __toString() method as abstract.
Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6053
Build 6073: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 11:14 PM
This revision was automatically updated to reflect the committed changes.