Page MenuHomePhabricator

Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION
ClosedPublic

Authored by joshuaspence on May 17 2015, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Nov 28, 7:40 AM
Unknown Object (File)
Mon, Nov 25, 7:20 PM
Unknown Object (File)
Sun, Nov 24, 6:58 AM
Unknown Object (File)
Fri, Nov 22, 11:12 AM
Unknown Object (File)
Fri, Nov 22, 11:12 AM
Unknown Object (File)
Fri, Nov 22, 11:12 AM
Unknown Object (File)
Fri, Nov 22, 10:49 AM
Unknown Object (File)
Sun, Nov 10, 8:09 AM
Subscribers

Details

Summary

The ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION linter rule was introduced in D12854, but fails for the following:

  • Interfaces which declare the __toString() method.
  • Classes which mark the __toString() method as abstract.
Test Plan

Added test cases.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6053
Build 6073: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence retitled this revision from to Improve ArcanistXHPASTLinter::LINT_TOSTRING_EXCEPTION.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 11:14 PM
This revision was automatically updated to reflect the committed changes.