Page MenuHomePhabricator

Projects - add mail to project updates
ClosedPublic

Authored by btrahan on May 15 2015, 10:29 PM.
Tags
None
Referenced Files
F15462064: D12868.id30952.diff
Tue, Apr 1, 12:47 PM
F15454176: D12868.diff
Sat, Mar 29, 4:48 PM
F15407919: D12868.id30955.diff
Tue, Mar 18, 8:14 PM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 8 2025, 4:36 AM
Unknown Object (File)
Feb 2 2025, 2:39 AM
Subscribers

Details

Summary

...which lets all the fancy settings for Email | Notify | Off be possible. Fixes T8164. Wasn't too sure the best way to break things up but members vs watchers felt meaningful to break out to me.

Also fixes a small bug where we were generating bad slug updated stories by messing with the signature of the slug data. Perhaps this fix isn't even good enough (the array_keys()) call and instead we'll need to implement transaction has effect and do a sort?

Test Plan

used ./bin/mail list-outbound and ./bin/mail show-outbound --id XX to verify reasonable emails were being generated. saw new preferences in settings.

Diff Detail

Repository
rP Phabricator
Branch
T8164
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 6020
Build 6040: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Projects - add mail to project updates.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Member/watcher stuff seems reasonable to me, too.

This revision is now accepted and ready to land.May 15 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.