Page MenuHomePhabricator

Projects - add mail to project updates
ClosedPublic

Authored by btrahan on May 15 2015, 10:29 PM.
Tags
None
Referenced Files
F14006216: D12868.id30952.diff
Mon, Oct 28, 3:20 AM
F14002268: D12868.diff
Fri, Oct 25, 5:06 PM
F14000490: D12868.id30952.diff
Thu, Oct 24, 10:17 PM
F13971686: D12868.id30955.diff
Thu, Oct 17, 2:43 PM
F13963521: D12868.id.diff
Tue, Oct 15, 4:24 PM
Unknown Object (File)
Oct 5 2024, 12:13 PM
Unknown Object (File)
Oct 2 2024, 5:03 AM
Unknown Object (File)
Sep 20 2024, 5:34 AM
Subscribers

Details

Summary

...which lets all the fancy settings for Email | Notify | Off be possible. Fixes T8164. Wasn't too sure the best way to break things up but members vs watchers felt meaningful to break out to me.

Also fixes a small bug where we were generating bad slug updated stories by messing with the signature of the slug data. Perhaps this fix isn't even good enough (the array_keys()) call and instead we'll need to implement transaction has effect and do a sort?

Test Plan

used ./bin/mail list-outbound and ./bin/mail show-outbound --id XX to verify reasonable emails were being generated. saw new preferences in settings.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Projects - add mail to project updates.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.

Member/watcher stuff seems reasonable to me, too.

This revision is now accepted and ready to land.May 15 2015, 10:57 PM
This revision was automatically updated to reflect the committed changes.