Differential D12865

[Redesign] New PHUIObjectItemListView
ClosedPublic
Actions

Authored by chad on May 15 2015, 7:54 PM.

Tags

None

Referenced Files

	F14826430: D12865.diff
	Wed, Jan 29, 1:30 AM

	F14823034: D12865.id30947.diff
	Tue, Jan 28, 10:44 AM

	F14822220: D12865.id30948.diff
	Tue, Jan 28, 7:41 AM

	Unknown Object (File)
	Mon, Jan 27, 5:52 AM

	Unknown Object (File)
	Fri, Jan 24, 4:33 AM

	Unknown Object (File)
	Fri, Jan 24, 4:33 AM

	Unknown Object (File)
	Fri, Jan 24, 4:33 AM

	Unknown Object (File)
	Fri, Jan 24, 4:33 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
rP46f6c2680eb5: [Redesign] New PHUIObjectItemListView

Summary

New, cleaner, ObjectItemLists. Lots of minor style tweaks, basic overview:

Remove FootIcons
Remove Stackable
Remove Plain List
Add StatusIcon
Add setting ObjectList to an ObjectBox
Minor retouches to Headers

Mostly, this should give us an idea of life with the new Object Lists. I'll take another application by application pass down the road. This mostly looks at implementation in Maniphest, Differential, Audit, Workboards. Checked a few other areas and dialogs while testing, and everything looks square.

Test Plan

Maniphest, Differential, Homepage, Audit, People, and other applications. Drag reorder, etc.

Diff Detail

Repository

Branch

object-list-status

Lint

Lint Passed

Severity	Location	Code	Message
Advice	src/applications/maniphest/view/ManiphestTaskListView.php:70	XHP16	TODO Comment

Unit

Tests Passed

Build Status

Buildable 6017
Build 6037: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30945.May 15 2015, 7:54 PM

chad retitled this revision from to [Redesign] New PHUIObjectItemListView.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 15 2015, 7:54 PM

Add a TODO

epriestley accepted this revision.May 15 2015, 8:24 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 15 2015, 8:24 PM

Closed by commit rP46f6c2680eb5: [Redesign] New PHUIObjectItemListView (authored by chad, committed by chad). · Explain WhyMay 15 2015, 8:29 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T8099: Mid-2015 Phabricator Redesign.May 16 2015, 2:47 AM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

20 lines

src/

applications/

almanac/

controller/

AlmanacConsoleController.php

5 lines

audit/

view/

PhabricatorAuditListView.php

5 lines

config/

controller/

PhabricatorConfigGroupController.php

3 lines

PhabricatorConfigIssueListController.php

1 line

PhabricatorConfigListController.php

3 lines

differential/

view/

DifferentialRevisionListView.php

11 lines

home/

controller/

PhabricatorHomeMainController.php

13 lines

maniphest/

view/

ManiphestTaskListView.php

8 lines

ManiphestTaskResultListView.php

55 lines

phortune/

controller/

PhortuneAccountListController.php

6 lines

project/

controller/

PhabricatorProjectBoardReorderController.php

9 lines

PhabricatorProjectMembersEditController.php

5 lines

settings/

panel/

PhabricatorHomePreferencesSettingsPanel.php

3 lines

subscriptions/

view/

SubscriptionListDialogBuilder.php

3 lines

tokens/

controller/

PhabricatorTokenGivenController.php

3 lines

PhabricatorTokenLeaderController.php

3 lines

uiexample/

examples/

PHUIObjectItemListExample.php

153 lines

view/

phui/

PHUIObjectBoxView.php

10 lines

PHUIObjectItemListView.php

20 lines

PHUIObjectItemView.php

78 lines

webroot/

rsrc/

css/

application/

maniphest/

batch-editor.css

2 lines

task-summary.css

41 lines

phui/

phui-header-view.css

6 lines

phui-object-item-list-view.css

131 lines

Diff 30947

resources/celerity/map.php

Loading...

src/applications/almanac/controller/AlmanacConsoleController.php

Loading...

src/applications/audit/view/PhabricatorAuditListView.php

Loading...

src/applications/config/controller/PhabricatorConfigGroupController.php

Loading...

src/applications/config/controller/PhabricatorConfigIssueListController.php

Loading...

src/applications/config/controller/PhabricatorConfigListController.php

Loading...

src/applications/differential/view/DifferentialRevisionListView.php

Loading...

src/applications/home/controller/PhabricatorHomeMainController.php

Loading...

src/applications/maniphest/view/ManiphestTaskListView.php

Loading...

src/applications/maniphest/view/ManiphestTaskResultListView.php

Loading...

src/applications/phortune/controller/PhortuneAccountListController.php

Loading...

src/applications/project/controller/PhabricatorProjectBoardReorderController.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersEditController.php

Loading...

src/applications/settings/panel/PhabricatorHomePreferencesSettingsPanel.php

Loading...

src/applications/subscriptions/view/SubscriptionListDialogBuilder.php

Loading...

src/applications/tokens/controller/PhabricatorTokenGivenController.php

Loading...

src/applications/tokens/controller/PhabricatorTokenLeaderController.php

Loading...

src/applications/uiexample/examples/PHUIObjectItemListExample.php

Loading...

src/view/phui/PHUIObjectBoxView.php

Loading...

src/view/phui/PHUIObjectItemListView.php

Loading...

src/view/phui/PHUIObjectItemView.php

Loading...

webroot/rsrc/css/application/maniphest/batch-editor.css

Loading...

webroot/rsrc/css/application/maniphest/task-summary.css

Loading...

webroot/rsrc/css/phui/phui-header-view.css

Loading...

webroot/rsrc/css/phui/phui-object-item-list-view.css

Loading...