Differential D12855

Add a linter rule for invalid default parameters
ClosedPublic
Actions

Authored by joshuaspence on May 15 2015, 8:31 AM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rARC60a5a2403360: Add a linter rule for invalid default parameters

Summary

See http://www.phpwtf.org/default-arguments-and-type-hinting.

Test Plan

Added test case.

Diff Detail

Repository

rARC Arcanist

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 6003
Build 6023: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30925.May 15 2015, 8:31 AM

joshuaspence retitled this revision from to Add a linter rule for invalid default parameters.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 15 2015, 8:31 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.May 17 2015, 12:59 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 17 2015, 12:59 PM

Rebase

Closed by commit rARC60a5a2403360: Add a linter rule for invalid default parameters (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 18 2015, 9:02 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

76 lines

__tests__/

xhpast/

invalid-default-paramter.lint-test

17 lines

Diff 30925

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/invalid-default-paramter.lint-test

Add a linter rule for invalid default parametersClosedPublicActions