Differential D12833

Replace user "status" with "availability"
ClosedPublic
Actions

Authored by epriestley on May 14 2015, 12:00 AM.

Tags

None

Referenced Files

	F14408614: D12833.id.diff
	Tue, Dec 24, 4:59 AM

	Unknown Object (File)
	Fri, Dec 20, 5:58 PM

	Unknown Object (File)
	Fri, Dec 20, 6:11 AM

	Unknown Object (File)
	Tue, Dec 17, 3:51 AM

	Unknown Object (File)
	Mon, Dec 16, 7:53 PM

	Unknown Object (File)
	Wed, Dec 11, 12:07 PM

	Unknown Object (File)
	Tue, Dec 10, 8:58 AM

	Unknown Object (File)
	Fri, Nov 29, 2:15 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T8183: Remove "Away" and "Sporadic" statuses.
T7707: Implement a read-through cache layer

Commits

Restricted Diffusion Commit
rPfef3c778fd45: Replace user "status" with "availability"

Summary

Ref T7707. Ref T8183.

Currently, user status is derived by looking at events they created. Instead, look at non-cancelled invites they are attending.
Prepare for on-user caching.
Mostly remove "Sporradic" as a status, although I left room for adding more information later.

Test Plan

Called user.query.
Viewed profile.
Viewed hovercard.
Used mentions.
Saw status immediately update when attending/leaving/cancelling a current event.
Created an event ending at 6 PM and an event from 6:10PM - 7PM, saw "Away until 7PM".

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30863.May 14 2015, 12:00 AM

epriestley retitled this revision from to Replace user "status" with "availability".

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7707: Implement a read-through cache layer, T8183: Remove "Away" and "Sporadic" statuses..

Herald added a reviewer: chad. · View Herald TranscriptMay 14 2015, 12:00 AM

Herald added a subscriber: epriestley. · View Herald Transcript

Spelling.

btrahan accepted this revision.May 14 2015, 5:45 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 14 2015, 5:45 PM

Closed by commit rPfef3c778fd45: Replace user "status" with "availability" (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2015, 6:15 PM

This revision was automatically updated to reflect the committed changes.

btrahan mentioned this in D12915: People - fix hovercards for people.May 18 2015, 9:59 PM

btrahan mentioned this in rP189c55d1d332: People - fix hovercards for people.May 18 2015, 10:39 PM

Revision Contents
Changeset List

Path

Size

resources/

celerity/

4 lines

src/

applications/

calendar/

storage/

PhabricatorCalendarEvent.php

12 lines

PhabricatorCalendarEventInvitee.php

4 lines

people/

conduit/

UserConduitAPIMethod.php

13 lines

UserQueryConduitAPIMethod.php

10 lines

controller/

PhabricatorPeopleProfileController.php

1 line

customfield/

PhabricatorUserStatusField.php

11 lines

event/

PhabricatorPeopleHovercardEventListener.php

38 lines

markup/

PhabricatorMentionRemarkupRule.php

19 lines

phid/

PhabricatorPeopleUserPHIDType.php

17 lines

query/

PhabricatorPeopleQuery.php

97 lines

storage/

PhabricatorUser.php

63 lines

webroot/

rsrc/

css/

layout/

phabricator-hovercard-view.css

1 line

Diff 30896

resources/celerity/map.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...

src/applications/calendar/storage/PhabricatorCalendarEventInvitee.php

Loading...

src/applications/people/conduit/UserConduitAPIMethod.php

Loading...

src/applications/people/conduit/UserQueryConduitAPIMethod.php

Loading...

src/applications/people/controller/PhabricatorPeopleProfileController.php

Loading...

src/applications/people/customfield/PhabricatorUserStatusField.php

Loading...

src/applications/people/event/PhabricatorPeopleHovercardEventListener.php

Loading...

src/applications/people/markup/PhabricatorMentionRemarkupRule.php

Loading...

src/applications/people/phid/PhabricatorPeopleUserPHIDType.php

Loading...

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...

src/applications/people/storage/PhabricatorUser.php

Loading...

webroot/rsrc/css/layout/phabricator-hovercard-view.css

Loading...