Page MenuHomePhabricator
Differential D12838

Add an availability cache for users
ClosedPublic
Actions

Authored by epriestley on May 14 2015, 3:55 PM.
Tags
None
Referenced Files
F13135229: D12838.diff
Thu, May 2, 7:41 AM
F13135176: D12838.diff
Thu, May 2, 7:23 AM
Unknown Object (File)
Thu, Apr 25, 1:32 PM
Unknown Object (File)
Thu, Apr 25, 1:32 PM
Unknown Object (File)
Thu, Apr 25, 1:32 PM
Unknown Object (File)
Thu, Apr 25, 1:32 PM
Unknown Object (File)
Thu, Apr 25, 2:35 AM
Unknown Object (File)
Sat, Apr 20, 7:37 PM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7707: Implement a read-through cache layer
Commits
Restricted Diffusion Commit
rPaa550189c788: Add an availability cache for users
Summary

Ref T7707. Caches availability on users to reduce the cost of loading handles. This cache is very slightly tricky to dirty properly.

Test Plan
  • Use DarkConsole to examine queries; saw cache hits, miss+fill, dirty.
  • Saw availability change correctly after canceling, joining, declining events.
  • Saw no queries to Calendar for pages with only availability data.

Diff Detail

Repository
rP Phabricator
Branch
fxform16
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5977
Build 5997: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30881.May 14 2015, 3:55 PM
epriestley retitled this revision from to Add an availability cache for users.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7707: Implement a read-through cache layer.
Herald added a subscriber: epriestley. · View Herald TranscriptMay 14 2015, 3:55 PM
epriestley updated this revision to Diff 30882.May 14 2015, 3:57 PM
  • Cleaner fix.
btrahan accepted this revision.May 14 2015, 5:51 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 14 2015, 5:51 PM
Closed by commit rPaa550189c788: Add an availability cache for users (authored by epriestley, committed by epriestley). · Explain WhyMay 14 2015, 6:15 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
sql/
autopatches/
5 lines
src/
applications/
calendar/
editor/
58 lines
storage/
13 lines
people/
query/
26 lines
storage/
52 lines

Diff 30882

View Options

resources/sql/autopatches/20150514.user.cache.2.sql

Loading...
View Options

src/applications/calendar/editor/PhabricatorCalendarEventEditor.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/people/query/PhabricatorPeopleQuery.php

Loading...
View Options

src/applications/people/storage/PhabricatorUser.php

Loading...
Phabricator · Built by Phacility