Page MenuHomePhabricator
Differential D12801

Cleaning up day view sidebar css
ClosedPublic
Actions

Authored by lpriestley on May 12 2015, 12:55 AM.
Tags
None
Referenced Files
F13282660: D12801.diff
Sun, Jun 2, 12:19 PM
F13267596: D12801.diff
Wed, May 29, 3:47 AM
F13266486: D12801.diff
Tue, May 28, 2:12 PM
F13258452: D12801.id30769.diff
Sun, May 26, 9:28 AM
F13258116: D12801.id30774.diff
Sun, May 26, 6:51 AM
F13256358: D12801.diff
Sat, May 25, 11:22 AM
F13231398: D12801.diff
Tue, May 21, 12:26 AM
F13220313: D12801.id30776.diff
Sun, May 19, 12:45 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP8465ef779e3b: Cleaning up day view sidebar css
Summary

Cleaning up day view sidebar css

Test Plan

All day events in day view sidebar should look like links, not boxes

Diff Detail

Repository
rP Phabricator
Branch
calendardaysidebarcss
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5910
Build 5930: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30769.May 12 2015, 12:55 AM
lpriestley retitled this revision from to Cleaning up day view sidebar css.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 12 2015, 12:55 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley updated this revision to Diff 30770.May 12 2015, 1:03 AM
lpriestley edited edge metadata.

css cleanup

Herald added a reviewer: chad. · View Herald TranscriptMay 12 2015, 1:03 AM
lpriestley updated this revision to Diff 30773.May 12 2015, 1:19 AM
lpriestley edited edge metadata.

correct diff

lpriestley updated this revision to Diff 30774.May 12 2015, 1:32 AM

code review

lpriestley updated this revision to Diff 30775.May 12 2015, 1:33 AM

cleanup

lpriestley updated this revision to Diff 30776.May 12 2015, 1:34 AM

more cleanup

epriestley accepted this revision.May 12 2015, 1:35 AM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 12 2015, 1:35 AM
Closed by commit rP8465ef779e3b: Cleaning up day view sidebar css (authored by lpriestley, committed by lpriestley). · Explain WhyMay 12 2015, 1:35 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
4 lines
src/
view/
phui/
calendar/
11 lines
6 lines
webroot/
rsrc/
css/
phui/
calendar/
4 lines

Diff 30775

View Options

resources/celerity/map.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
Phabricator · Built by Phacility