Differential D12795

Refine durable column class toggling
ClosedPublic
Actions

Authored by btrahan on May 11 2015, 8:46 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T8151: Decide the fate of JX.Scrollbar

Commits

Restricted Diffusion Commit
rP8056719eee5b: Refine durable column class toggling

Summary

don't bother with margin class if column isn't visible. Ref T8151.

Test Plan

using chrome with trackpad

loaded home with toggled off column - noted no margin class erroneously applied
toggled column off and on - correct
loaded home with toggled on column - correct
toggled column off and on - correct

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5897
Build 5917: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30759.May 11 2015, 8:46 PM

btrahan retitled this revision from to Refine durable column class toggling.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

btrahan added a task: T8151: Decide the fate of JX.Scrollbar.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 11 2015, 8:46 PM

Thanks!

This revision is now accepted and ready to land.May 11 2015, 8:48 PM

Closed by commit rP8056719eee5b: Refine durable column class toggling (authored by btrahan, committed by btrahan). · Explain WhyMay 11 2015, 8:50 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

map.php

42 lines

webroot/

rsrc/

js/

application/

conpherence/

behavior-durable-column.js

10 lines

Diff 30759

View Options

resources/celerity/map.php