Page MenuHomePhabricator

Conpherence - improve performance by handling dropdowns (notifications, threads) as standard response data
ClosedPublic

Authored by btrahan on May 7 2015, 10:38 PM.
Tags
None
Referenced Files
F14043064: D12761.id30678.diff
Tue, Nov 12, 7:29 AM
F14018078: D12761.id30673.diff
Tue, Nov 5, 4:09 AM
F14001499: D12761.diff
Fri, Oct 25, 8:44 AM
F13981636: D12761.id.diff
Oct 19 2024, 6:00 PM
F13980492: D12761.id30678.diff
Oct 19 2024, 11:03 AM
F13975063: D12761.diff
Oct 18 2024, 8:33 AM
F13971826: D12761.id30673.diff
Oct 17 2024, 3:33 PM
F13966593: D12761.id30673.diff
Oct 16 2024, 8:37 AM
Subscribers

Details

Summary

Ref T7708. Rather than invoking the general client -> server dropdown refresh path, return the data with the various conpherence requests and update the dropdowns that way. Saves 2 client -> server requests per conpherence action.

Test Plan

loaded up /conpherence/ and noted message count deduct correctly. clicked specific message and noted message count deduct successfully. did same two tests via durable column and again saw message counts deduct successfully.

Diff Detail

Repository
rP Phabricator
Branch
T7708_2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5844
Build 5864: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan retitled this revision from to Conpherence - improve performance by handling dropdowns (notifications, threads) as standard response data.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.

name stratcom event from conpherence-redraw to conpherence-redraw-aphlict for more tight scoping

epriestley edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 11:01 PM
btrahan edited edge metadata.

rebase, celerity

This revision was automatically updated to reflect the committed changes.