Differential D12761

Conpherence - improve performance by handling dropdowns (notifications, threads) as standard response data
ClosedPublic
Actions

Authored by btrahan on May 7 2015, 10:38 PM.

Tags

None

Referenced Files

	F14347896: D12761.diff
	Thu, Dec 19, 3:53 AM

	Unknown Object (File)
	Mon, Dec 16, 2:22 AM

	Unknown Object (File)
	Sun, Dec 8, 6:25 AM

	Unknown Object (File)
	Sat, Dec 7, 12:40 AM

	Unknown Object (File)
	Fri, Dec 6, 9:15 AM

	Unknown Object (File)
	Wed, Nov 27, 4:54 AM

	Unknown Object (File)
	Wed, Nov 27, 3:41 AM

	Unknown Object (File)
	Tue, Nov 26, 7:43 AM

Subscribers

Details

Reviewers

Maniphest Tasks

T7708: Improve performance of chat column

Commits

Restricted Diffusion Commit
rP33e7038b96f1: Conpherence - improve performance by handling dropdowns (notifications…

Summary

Ref T7708. Rather than invoking the general client -> server dropdown refresh path, return the data with the various conpherence requests and update the dropdowns that way. Saves 2 client -> server requests per conpherence action.

Test Plan

loaded up /conpherence/ and noted message count deduct correctly. clicked specific message and noted message count deduct successfully. did same two tests via durable column and again saw message counts deduct successfully.

Diff Detail

Repository

Branch

T7708_2

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5844
Build 5864: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30671.May 7 2015, 10:38 PM

btrahan added a task: T7708: Improve performance of chat column.

btrahan retitled this revision from to Conpherence - improve performance by handling dropdowns (notifications, threads) as standard response data.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 7 2015, 10:38 PM

name stratcom event from conpherence-redraw to conpherence-redraw-aphlict for more tight scoping

epriestley accepted this revision.May 7 2015, 11:01 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 7 2015, 11:01 PM

rebase, celerity

Closed by commit rP33e7038b96f1: Conpherence - improve performance by handling dropdowns (notifications… (authored by btrahan, committed by btrahan). · Explain WhyMay 7 2015, 11:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

52 lines

src/

applications/

conpherence/

controller/

ConpherenceColumnViewController.php

7 lines

ConpherenceUpdateController.php

9 lines

ConpherenceViewController.php

7 lines

webroot/

rsrc/

js/

application/

aphlict/

behavior-aphlict-dropdown.js

37 lines

conpherence/

ConpherenceThreadManager.js

10 lines

Diff 30671

resources/celerity/map.php

Loading...

src/applications/conpherence/controller/ConpherenceColumnViewController.php

Loading...

src/applications/conpherence/controller/ConpherenceUpdateController.php

Loading...

src/applications/conpherence/controller/ConpherenceViewController.php

Loading...

webroot/rsrc/js/application/aphlict/behavior-aphlict-dropdown.js

Loading...

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...