Page MenuHomePhabricator
Differential D12755

Conpherence - improve reliability of message delivery
ClosedPublic
Actions

Authored by btrahan on May 7 2015, 6:11 PM.
Tags
None
Referenced Files
F14041045: D12755.diff
Mon, Nov 11, 3:34 PM
F14023626: D12755.diff
Thu, Nov 7, 3:15 AM
F13998842: D12755.id30658.diff
Thu, Oct 24, 11:29 AM
F13969764: D12755.id.diff
Oct 17 2024, 3:44 AM
F13969655: D12755.id30657.diff
Oct 17 2024, 3:34 AM
F13969651: D12755.id30658.diff
Oct 17 2024, 3:34 AM
F13968995: D12755.id.diff
Oct 16 2024, 11:51 PM
F13968644: D12755.diff
Oct 16 2024, 10:31 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI
T7755: Improve reliability of real-time notification delivery
Commits
Restricted Diffusion Commit
rP791e897c0d0f: Conpherence - improve reliability of message delivery
Summary

Ref T7755. T7755#107290 reproduced for me reliably and now it does not. Cleaned up the logic around in flight updates as it was not correct.

Not sure this is enough to close T7755, but maybe?

Test Plan

T7755#107290 no longer reproduces!

Diff Detail

Repository
rP Phabricator
Branch
T7755
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5834
Build 5854: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30657.May 7 2015, 6:11 PM
btrahan added a task: T7755: Improve reliability of real-time notification delivery.
btrahan retitled this revision from to Conpherence - improve reliability of message delivery.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 7 2015, 6:11 PM
btrahan added a task: T6713: Adding a comment to a conpherence sometimes duplicates the message in the UI.May 7 2015, 6:16 PM
epriestley accepted this revision.May 7 2015, 6:26 PM
epriestley edited edge metadata.

I was able to repro some of this stuff pretty reliably -- land this and I'll bang on it for a bit and see if I can still repro?

This revision is now accepted and ready to land.May 7 2015, 6:26 PM
Closed by commit rP791e897c0d0f: Conpherence - improve reliability of message delivery (authored by btrahan, committed by btrahan). · Explain WhyMay 7 2015, 6:26 PM
This revision was automatically updated to reflect the committed changes.
btrahan added a comment.May 7 2015, 6:27 PM

Thanks! Repro cases help a ton if you still got any. :D

Revision Contents
Changeset List

PathSize
resources/
celerity/
26 lines
webroot/
rsrc/
js/
application/
conpherence/
16 lines

Diff 30657

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/js/application/conpherence/ConpherenceThreadManager.js

Loading...
Phabricator · Built by Phacility