Page MenuHomePhabricator

Make --conduit-token work without requiring .arcrc
ClosedPublic

Authored by epriestley on May 7 2015, 1:10 PM.
Tags
None
Referenced Files
F14841684: D12750.id30653.diff
Sat, Feb 1, 5:48 PM
Unknown Object (File)
Fri, Jan 31, 9:05 AM
Unknown Object (File)
Wed, Jan 29, 4:32 PM
Unknown Object (File)
Mon, Jan 27, 3:41 AM
Unknown Object (File)
Sat, Jan 25, 8:36 PM
Unknown Object (File)
Fri, Jan 24, 4:12 AM
Unknown Object (File)
Fri, Jan 24, 4:12 AM
Unknown Object (File)
Fri, Jan 24, 4:12 AM

Details

Summary

Ref T5955. This logic is a little cleaner than the previous version.

Don't require ~/.arcrc to exist if the caller provides --conduit-token.

Test Plan
  • Made calls with --conduit-token and no ~/.arcrc.
  • Made calls with --conduit-token and a normal ~/.arcrc.
  • Made calls with normal arc.

Diff Detail

Repository
rARC Arcanist
Branch
token2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5827
Build 5847: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley retitled this revision from to Make --conduit-token work without requiring .arcrc.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.May 7 2015, 5:49 PM
This revision was automatically updated to reflect the committed changes.