Paths

Table of Contentst

Differential D12749

Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields
ClosedPublic
Actions

Authored by epriestley on May 7 2015, 1:01 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, May 7, 3:34 PM

	Unknown Object (File)
	Tue, May 6, 9:29 AM

	Unknown Object (File)
	Tue, Apr 29, 3:19 PM

	Unknown Object (File)
	Mon, Apr 28, 8:00 PM

	Unknown Object (File)
	Sun, Apr 27, 4:05 PM

	Unknown Object (File)
	Sat, Apr 26, 6:52 AM

	Unknown Object (File)
	Fri, Apr 25, 9:48 PM

	Unknown Object (File)
	Fri, Apr 25, 1:30 PM

Subscribers

Tokens

"Orange Medal" token, awarded by cburroughs.

Details

Reviewers

Maniphest Tasks

T8087: Let Phabricator parse either "Dxxx" (no URI) or "https://secure.phabricator.com/Dxxx" (full URI) in Differential Revisions

Commits

Restricted Diffusion Commit
rP88b1ad7e92e5: Allow Phabricator to parse bare revision IDs from "Differential Revision:"…

Summary

Fixes T8087. Depends on D12748.

Test Plan

Diff Detail

Repository

Branch

fulluri1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5826
Build 5846: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30635.May 7 2015, 1:01 PM

epriestley retitled this revision from to Allow Phabricator to parse bare revision IDs from "Differential Revision:" fields.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T8087: Let Phabricator parse either "Dxxx" (no URI) or "https://secure.phabricator.com/Dxxx" (full URI) in Differential Revisions.

epriestley added a parent revision: D12748: Allow Arcanist to parse bare revision IDs from "Differential Revisions:" field.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 7 2015, 1:01 PM

epriestley added a subscriber: cburroughs.May 7 2015, 1:03 PM

epriestley added inline comments.

src/applications/differential/customfield/DifferentialRevisionIDField.php
50–51	@cburroughs, to get the short `D123` behavior (instead of full URIs) in advance of T6030: Wait for D12748 + D12749 (this change). Get everyone to upgrade "arc" past D12748. Make this change: - return PhabricatorEnv::getProductionURI('/D'.$id); + return 'D'.$id;

cburroughs awarded a token.May 7 2015, 4:24 PM

btrahan accepted this revision.May 7 2015, 5:44 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.May 7 2015, 5:44 PM

Closed by commit rP88b1ad7e92e5: Allow Phabricator to parse bare revision IDs from "Differential Revision:"… (authored by epriestley, committed by epriestley). · Explain WhyMay 7 2015, 6:10 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

customfield/

DifferentialRevisionIDField.php

8 lines

Diff 30635

src/applications/differential/customfield/DifferentialRevisionIDField.php

Loading...