Redesign main header
ClosedPublic
Actions

Authored by chad on May 7 2015, 3:57 AM.

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T8099: Mid-2015 Phabricator Redesign

Commits

Restricted Diffusion Commit
Restricted Diffusion Commit
rP476b7ef81611: Redesign main header
rPcd98f2a31be0: Redesign main header

Summary

First cut of redesign branch, simpler, lighter header. Will check in new graphics in follow up diff.

Test Plan

Mostly all just new colors, but this also removes setting of header-color in Config.

Diff Detail

Repository

rP Phabricator

Branch

redesign-2015

Lint

Lint Skipped

Unit

Tests Passed

Build Status

Buildable 5815
Build 5835: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30624.May 7 2015, 3:57 AM

chad retitled this revision from to Redesign main header.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 7 2015, 3:57 AM

lint

epriestley accepted this revision.May 7 2015, 12:05 PM

epriestley edited edge metadata.

epriestley added inline comments.

src/view/page/menu/PhabricatorMainMenuView.php
86	If this removal is permanent, you should remove the config option too and mark it obsolete in `PhabricatorExtraConfigSetupCheck` (or file a task so I can remember to do it if you aren't sure about it).

This revision is now accepted and ready to land.May 7 2015, 12:05 PM

I'm like 98% sure we should remove it. I think changing header logo should take its place. At least, I can't think of a good reason beyond that to keep it.

Closed by commit rPcd98f2a31be0: Redesign main header (authored by chad, committed by chad). · Explain WhyMay 7 2015, 3:34 PM

This revision was automatically updated to reflect the committed changes.

chad added a task: T8099: Mid-2015 Phabricator Redesign.May 7 2015, 4:35 PM