Paths

Table of Contentst

Differential D12707

Fix failing XHPAST unit tests
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 9:31 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Commits

rPHU928eb14b02a5: Fix failing XHPAST unit tests

Summary

These unit tests are failing at HEAD.

Test Plan

I have no idea if these are actually "correct" since the data is not in a human-readable format.

Diff Detail

Repository

rPHU libphutil

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5749
Build 5768: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30515.May 4 2015, 9:31 PM

joshuaspence retitled this revision from to Fix failing XHPAST unit tests.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 9:31 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Bump

epriestley accepted this revision.May 19 2015, 2:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 19 2015, 2:06 PM

Closed by commit rPHU928eb14b02a5: Fix failing XHPAST unit tests (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 19 2015, 8:59 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

parser/

xhpast/

__tests__/

data/

php-access-on-instanciation.expect

12 lines

php-syntax.php.expect

98 lines

php-traits.php.expect

8 lines

Diff 30515

View Options

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

View Options

src/parser/xhpast/tests/data/php-syntax.php.expect

View Options

src/parser/xhpast/tests/data/php-traits.php.expect

Fix failing XHPAST unit testsClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 30515

src/parser/xhpast/__tests__/data/php-access-on-instanciation.expect

src/parser/xhpast/__tests__/data/php-syntax.php.expect

src/parser/xhpast/__tests__/data/php-traits.php.expect

Fix failing XHPAST unit tests
ClosedPublic
Actions

Revision Contents
Changeset List

src/parser/xhpast/tests/data/php-access-on-instanciation.expect

src/parser/xhpast/tests/data/php-syntax.php.expect

src/parser/xhpast/tests/data/php-traits.php.expect