Paths

Table of Contentst

Differential D12706

Fix a failing XML unit test
ClosedPublic
Actions

Authored by joshuaspence on May 4 2015, 9:30 PM.

Tags

None

Referenced Files

	F15419581: D12706.id30530.diff
	Fri, Mar 21, 7:09 AM

	F15346011: D12706.id30514.diff
	Mon, Mar 10, 1:41 PM

	F15284025: D12706.diff
	Tue, Mar 4, 9:05 AM

	Unknown Object (File)
	Feb 8 2025, 4:17 AM

	Unknown Object (File)
	Jan 24 2025, 4:01 AM

	Unknown Object (File)
	Jan 22 2025, 3:09 PM

	Unknown Object (File)
	Jan 18 2025, 1:57 AM

	Unknown Object (File)
	Jan 16 2025, 11:37 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7215: ArcanistXMLLinterTestCase test failure

Commits

rARC0a711315f86b: Fix a failing XML unit test

Summary

Ref T7215. This test case is consistently failing locally (with a LIBXML_VERSION of 20902).

Test Plan

arc unit

Diff Detail

Repository

Branch

master

Lint

Lint Errors

Severity	Location	Code	Message
Error	src/lint/linter/__tests__/xml/attr4.lint-test:1	TXT5	Bad Charset

Unit

Test Failures

Build Status

Buildable 5748
Build 5767: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	2,560 ms	ArcanistPuppetLintLinterTestCase::testLinter
	1,340 ms	ArcanistXMLLinterTestCase::testLinter
	1,312 ms	ArcanistCSSLintLinterTestCase::testLinter
	151 ms	ArcanistCSSLintLinterTestCase::testVersion
	268 ms	ArcanistChmodLinterTestCase::testLinter
		View Full Test Results (2 Failed · 46 Passed · 5 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30514.May 4 2015, 9:30 PM

joshuaspence retitled this revision from to Fix a failing XML unit test.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7215: ArcanistXMLLinterTestCase test failure.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 4 2015, 9:30 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

Maybe we should just throw this test away given that the result seems version-dependent?

This revision is now accepted and ready to land.May 4 2015, 9:31 PM

Yeah maybe. Let me see how many of the tests are failing.

Closed by commit rARC0a711315f86b: Fix a failing XML unit test (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 5 2015, 8:57 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

__tests__/

xml/

attr4.lint-test

2 lines

Diff 30514

src/lint/linter/tests/xml/attr4.lint-test

Loading...