Page MenuHomePhabricator
Differential D12702

Remove click to view on ghosties
ClosedPublic
Actions

Authored by chad on May 4 2015, 6:17 PM.
Tags
None
Referenced Files
F13285382: D12702.diff
Mon, Jun 3, 7:49 PM
F13275303: D12702.diff
Fri, May 31, 4:38 AM
F13265353: D12702.id30503.diff
Tue, May 28, 3:39 AM
F13262165: D12702.diff
Mon, May 27, 1:50 AM
F13224557: D12702.id.diff
Sun, May 19, 9:11 AM
F13213788: D12702.diff
Fri, May 17, 8:05 AM
F13184845: D12702.id30497.diff
Sat, May 11, 12:51 AM
F13180557: D12702.id30497.diff
Thu, May 9, 12:56 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Maniphest Tasks
T7447: Bring inline comments forward across revision updates
Commits
Restricted Diffusion Commit
rP861155ea73ea: Remove click to view on ghosties
Summary

Ref T7447, these are more work than needed at least on an indivdual basis. JS openning all feels poor as well.

Test Plan

Review comments, past present and future.

Diff Detail

Repository
rP Phabricator
Branch
ghost-17
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5743
Build 5762: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 30497.May 4 2015, 6:17 PM
chad retitled this revision from to Remove click to view on ghosties.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
chad added a task: T7447: Bring inline comments forward across revision updates.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMay 4 2015, 6:17 PM
epriestley added inline comments.May 4 2015, 6:34 PM
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
149–150

Let me get you a diff for this, I think it's a little bit of work.

epriestley edited edge metadata.May 4 2015, 6:34 PM

Oh, I know how I can cheat though.

chad marked an inline comment as done.May 4 2015, 6:35 PM
epriestley mentioned this in D12703: Provide link to inlines in-context in $ghost['href'].May 4 2015, 6:45 PM
epriestley accepted this revision.May 4 2015, 6:45 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php
149–150

D12703 should give you the link in $ghost['href'], let me know if that doesn't work.

Possibly this should have target="_blank"?

This revision is now accepted and ready to land.May 4 2015, 6:45 PM
chad updated this revision to Diff 30500.May 4 2015, 6:50 PM
chad edited edge metadata.
  • Update link
chad marked an inline comment as done.May 4 2015, 6:51 PM
epriestley mentioned this in rP460d68ba27b6: Provide link to inlines in-context in $ghost['href'].May 4 2015, 6:52 PM
Closed by commit rP861155ea73ea: Remove click to view on ghosties (authored by chad, committed by chad). · Explain WhyMay 4 2015, 6:59 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
infrastructure/
diff/
view/
16 lines
webroot/
rsrc/
css/
application/
differential/
19 lines

Diff 30500

View Options

resources/celerity/map.php

Loading...
View Options

src/infrastructure/diff/view/PHUIDiffInlineCommentDetailView.php

Loading...
View Options

webroot/rsrc/css/application/differential/phui-inline-comment.css

Loading...
Phabricator · Built by Phacility