Page MenuHomePhabricator
Differential D12700

Make calendar day view events fill up the correctly sized slots
ClosedPublic
Actions

Authored by lpriestley on May 4 2015, 5:37 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:33 AM
Unknown Object (File)
Thu, May 2, 8:26 AM
Unknown Object (File)
Mon, Apr 29, 2:06 PM
Unknown Object (File)
Wed, Apr 24, 10:10 PM
Unknown Object (File)
Sun, Apr 21, 4:34 PM
Unknown Object (File)
Fri, Apr 19, 4:41 PM
Unknown Object (File)
Fri, Apr 19, 8:44 AM
Unknown Object (File)
Fri, Apr 19, 8:44 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4393: Implement "Daily/Weekly" Calendar Mock
Commits
Restricted Diffusion Commit
rP853f42e97d9c: Make calendar day view events fill up the correctly sized slots
Summary

Ref T4393, Make calendar day view events fill up the correctly sized slots. (not handling overlapping slots)

Test Plan

Create an event 4:30-5:30am. Day view should correctly reflect when event happens.

Diff Detail

Repository
rP Phabricator
Branch
calendardayslots
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5738
Build 5757: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30491.May 4 2015, 5:37 PM
lpriestley retitled this revision from to Make calendar day view events fill up the correctly sized slots.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T4393: Implement "Daily/Weekly" Calendar Mock.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptMay 4 2015, 5:37 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.May 4 2015, 5:39 PM
epriestley edited edge metadata.
epriestley added inline comments.
src/view/phui/calendar/PHUICalendarDayView.php
125

Maybe put this in CSS since it's static.

This revision is now accepted and ready to land.May 4 2015, 5:39 PM
lpriestley updated this revision to Diff 30492.May 4 2015, 5:52 PM
lpriestley edited edge metadata.

Moving static css into css file

lpriestley updated this revision to Diff 30493.May 4 2015, 5:52 PM

Rebuilding css

lpriestley marked an inline comment as done.May 4 2015, 5:52 PM
Closed by commit rP853f42e97d9c: Make calendar day view events fill up the correctly sized slots (authored by lpriestley, committed by lpriestley). · Explain WhyMay 4 2015, 5:53 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
phui/
calendar/
28 lines
webroot/
rsrc/
css/
phui/
calendar/
3 lines

Diff 30492

View Options

src/view/phui/calendar/PHUICalendarDayView.php

Loading...
View Options

webroot/rsrc/css/phui/calendar/phui-calendar-day.css

Loading...
Phabricator · Built by Phacility