Add "and" support to "ref"
ClosedPublic
Actions

Authored by joshuaspence on May 3 2015, 9:29 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

Restricted Maniphest Task
Restricted Maniphest Task
Restricted Maniphest Task
T8038: "Ref" syntax doesn't support "and"

Commits

Restricted Diffusion Commit
rP6bebb3c69a07: Add "and" support to "ref"

Summary

Fixes T8038. Allow PhabricatorCustomFieldMonogramParser to handle "and". This means that Ref Tx, Ty and Tz will correctly return array('monograms' => array('Tx', 'Ty', 'Tz').

Test Plan

Added unit tests.

Diff Detail

Repository

rP Phabricator

Branch

master

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5717
Build 5736: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

joshuaspence updated this revision to Diff 30447.May 3 2015, 9:29 PM

joshuaspence retitled this revision from to Add "and" support to "ref".

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a task: T8038: "Ref" syntax doesn't support "and".

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 3 2015, 9:29 PM

Herald added a subscriber: epriestley. · View Herald Transcript

I'd maybe expect this to be:

- ...[,\s]*...
+ ...(?:,|\s|and)*...

That will allow T1, and,, and and, and T2, but that seems fine.

Further progress

It's not caused by this diff, but I don't like how we currently parse 'Fixes T1,,, T2 T3' => array('monograms' => 'T1', 'T2', 'T3')... this just seems odd (although I doubt it causes any real issues).

epriestley accepted this revision.May 4 2015, 12:06 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.May 4 2015, 12:06 PM

Closed by commit rP6bebb3c69a07: Add "and" support to "ref" (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 4 2015, 9:14 PM

This revision was automatically updated to reflect the committed changes.