Page MenuHomePhabricator

Scope remarkup highlighting better
ClosedPublic

Authored by chad on May 2 2015, 3:59 PM.
Tags
None
Referenced Files
F15529018: D12657.diff
Tue, Apr 22, 4:06 PM
F15505934: D12657.diff
Tue, Apr 15, 7:02 AM
F15487165: D12657.id30402.diff
Thu, Apr 10, 11:40 AM
F15467323: D12657.id30402.diff
Thu, Apr 3, 2:04 PM
F15463483: D12657.diff
Wed, Apr 2, 12:03 AM
F15448786: D12657.id.diff
Fri, Mar 28, 6:54 AM
F15445555: D12657.id30402.diff
Thu, Mar 27, 2:35 PM
F15442367: D12657.id30402.diff
Wed, Mar 26, 10:58 PM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP3da020b4931c: Scope remarkup highlighting better
Summary

These remarkup spans bleed into other areas, but afaik they only seem to be needed on the bright rule. Also normalized the height of the label, which changed when we changed button size.

Test Plan

Review many diffs and inline comments. If this rule altered something else I can't find, let me know?

Diff Detail

Repository
rP Phabricator
Branch
ghost-16
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5676
Build 5695: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Scope remarkup highlighting better.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 2 2015, 4:00 PM
This revision was automatically updated to reflect the committed changes.