Page MenuHomePhabricator

Scope remarkup highlighting better
ClosedPublic

Authored by chad on May 2 2015, 3:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Nov 23, 8:47 AM
Unknown Object (File)
Mon, Nov 18, 5:29 PM
Unknown Object (File)
Thu, Nov 14, 4:41 PM
Unknown Object (File)
Wed, Nov 13, 2:17 AM
Unknown Object (File)
Mon, Nov 11, 2:22 PM
Unknown Object (File)
Wed, Nov 6, 11:01 PM
Unknown Object (File)
Sun, Nov 3, 8:25 AM
Unknown Object (File)
Oct 26 2024, 6:51 AM
Subscribers

Details

Reviewers
epriestley
Commits
Restricted Diffusion Commit
rP3da020b4931c: Scope remarkup highlighting better
Summary

These remarkup spans bleed into other areas, but afaik they only seem to be needed on the bright rule. Also normalized the height of the label, which changed when we changed button size.

Test Plan

Review many diffs and inline comments. If this rule altered something else I can't find, let me know?

Diff Detail

Repository
rP Phabricator
Branch
ghost-16
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5676
Build 5695: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad retitled this revision from to Scope remarkup highlighting better.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 2 2015, 4:00 PM
This revision was automatically updated to reflect the committed changes.