Ref T7986, Ability to join or decline an event.
Details
Details
- Reviewers
epriestley - Group Reviewers
Blessed Reviewers - Maniphest Tasks
- T7986: Inviting people and RSVP'ing to a Calendar event.
- Commits
- Restricted Diffusion Commit
rP39e252caf521: Ability to join or decline an event
Open Calendar event, join event, Invitee list should update. Decline event, invitee list should remove you.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- calendareventjoindecline
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5601 Build 5620: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
Some nitpicks / suggestions, didn't catch anything substantive.
| src/applications/calendar/controller/PhabricatorCalendarEventJoinController.php | ||
|---|---|---|
| 7–14 | For modern controllers, you can simplify this a bit. Instead of processRequest(), do: public function handleRequest(AphrontRequest $request) {Then do this to read the 'id' value: $request->getURIData('id'); | |
| 15 | In modern code, prefer: $viewer = $this->getViewer(); | |
| 22–26 | You can remove this, since we aren't requiring CAN_EDIT to join events (just CAN_VIEW). | |
| 39 | Unused. | |
| 70 | You can just omit this, the default button name is "Cancel" if you don't pass an alternate name. | |
| src/applications/calendar/controller/PhabricatorCalendarEventViewController.php | ||
| 72 | Now unused. | |
| 99 | Is there a better icon for this? fa-user-minus or something? | |
| 101 | No need for $can_edit to join events. | |
| 109 | As above. | |
| src/applications/calendar/storage/PhabricatorCalendarEvent.php | ||
| 137–138 | If something passes a bad PHID, this could fatal. Maybe do this between these lines: if (!$invited) {
return blahblah::STATUS_UNINVITED;
} | |