Page MenuHomePhabricator
Differential D12609

Improve ref resolution for Git branches and tags
ClosedPublic
Actions

Authored by epriestley on Apr 29 2015, 3:17 PM.
Tags
None
Referenced Files
F15631907: D12609.diff
Mon, May 19, 12:31 PM
Unknown Object (File)
Thu, Apr 24, 9:59 AM
Unknown Object (File)
Apr 11 2025, 3:16 PM
Unknown Object (File)
Apr 4 2025, 4:26 AM
Unknown Object (File)
Mar 14 2025, 9:13 PM
Unknown Object (File)
Feb 8 2025, 4:05 AM
Unknown Object (File)
Feb 8 2025, 1:13 AM
Unknown Object (File)
Jan 31 2025, 7:01 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
Maniphest Tasks
T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs
Commits
Restricted Diffusion Commit
rP28d00948568d: Improve ref resolution for Git branches and tags
Summary

Fixes T7982.

  • When resolving branches, make sure they get type 'branch'.
  • Correctly resolve refs when a repository has a branch and tag with the same name.
Test Plan

Disabled ref cache and resolved refs in a Git repository with a 'master' tag and a 'master' branch. Saw refs resolve accurately.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 30273.Apr 29 2015, 3:17 PM
epriestley retitled this revision from to Improve ref resolution for Git branches and tags.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T7982: DiffusionLowLevelResolveRefsQuery incorrectly identifies branch refs as commit refs.
Herald added a subscriber: epriestley. · View Herald TranscriptApr 29 2015, 3:17 PM
epriestley added inline comments.Apr 29 2015, 3:18 PM
src/applications/diffusion/request/DiffusionGitRequest.php
23–30

This also removes this implementation detail entirely behind the API.

btrahan accepted this revision.Apr 29 2015, 6:03 PM
btrahan edited edge metadata.
This revision is now accepted and ready to land.Apr 29 2015, 6:03 PM
Closed by commit rP28d00948568d: Improve ref resolution for Git branches and tags (authored by epriestley, committed by epriestley). · Explain WhyApr 29 2015, 8:21 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
query/
lowlevel/
105 lines
59 lines
request/
9 lines
6 lines

Diff 30281

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelGitRefQuery.php

Loading...
View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php

Loading...
View Options

src/applications/diffusion/request/DiffusionGitRequest.php

Loading...
View Options

src/applications/diffusion/request/DiffusionRequest.php

Loading...
Phabricator · Built by Phacility