Page MenuHomePhabricator
Differential D12599

Quicksand - fix project board page and quicksand
ClosedPublic
Actions

Authored by btrahan on Apr 28 2015, 8:03 PM.
Tags
None
Referenced Files
F14015679: D12599.id30257.diff
Sun, Nov 3, 11:40 PM
F14009559: D12599.id.diff
Wed, Oct 30, 7:59 PM
F13997333: D12599.diff
Thu, Oct 24, 3:46 AM
F13997238: D12599.id.diff
Thu, Oct 24, 3:09 AM
F13986773: D12599.id30253.diff
Mon, Oct 21, 5:29 AM
F13959193: D12599.id.diff
Oct 14 2024, 6:14 PM
Unknown Object (File)
Oct 11 2024, 2:23 PM
Unknown Object (File)
Oct 10 2024, 8:20 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Maniphest Tasks
T7913: Quicksand doesn't play nice with project workboards
Commits
Restricted Diffusion Commit
rP00f864b35930: Quicksand - fix project board page and quicksand
Summary

Fixes T7913. Collapse the separate board dropdown into the board projects behavior; we always need that anyway and now we can install the listener more granularly.

Test Plan
  • visted project board
  • invoked create task, cancelled dialog
  • visited project feed
  • visited project board
  • invoked create task, cancelled dialog (FAILED pre patch...!)

Diff Detail

Repository
rP Phabricator
Branch
T7913
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5573
Build 5592: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

btrahan updated this revision to Diff 30253.Apr 28 2015, 8:03 PM
btrahan added a task: T7913: Quicksand doesn't play nice with project workboards.
btrahan retitled this revision from to Quicksand - fix project board page and quicksand.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 28 2015, 8:03 PM
epriestley accepted this revision.Apr 28 2015, 9:50 PM
epriestley edited edge metadata.
epriestley added inline comments.
webroot/rsrc/js/core/behavior-dark-console.js
41

oops, haha

This revision is now accepted and ready to land.Apr 28 2015, 9:50 PM
Closed by commit rP00f864b35930: Quicksand - fix project board page and quicksand (authored by btrahan, committed by btrahan). · Explain WhyApr 28 2015, 9:51 PM
This revision was automatically updated to reflect the committed changes.
cburroughs mentioned this in D10610: A batch editable page for viewing a single board column.May 13 2015, 7:25 PM

Revision Contents
Changeset List

PathSize
resources/
celerity/
62 lines
src/
applications/
base/
controller/
13 lines
project/
controller/
20 lines
view/
page/
5 lines
webroot/
rsrc/
externals/
javelin/
lib/
6 lines
js/
application/
projects/
205 lines
core/
1 line

Diff 30253

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/base/controller/PhabricatorController.php

Loading...
View Options

src/applications/project/controller/PhabricatorProjectBoardViewController.php

Loading...
View Options

src/view/page/PhabricatorStandardPageView.php

Loading...
View Options

webroot/rsrc/externals/javelin/lib/Quicksand.js

Loading...
View Options

webroot/rsrc/js/application/projects/behavior-boards-dropdown.js

Loading...
View Options

webroot/rsrc/js/application/projects/behavior-project-boards.js

Loading...
View Options

webroot/rsrc/js/core/behavior-dark-console.js

Loading...
Phabricator · Built by Phacility