Differential D12592

Fixing some calendar event timeline issues.
ClosedPublic
Actions

Authored by lpriestley on Apr 28 2015, 3:40 PM.

Details

Reviewers

epriestley

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7953: Give calendar events names

Commits

Restricted Diffusion Commit
rPd816ac0b01d7: Fixing some calendar event timeline issues.

Summary

Ref T7953, Fixing some calendar event timeline issues.

Test Plan

Create event, event timeline should reflect the transaction.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30232.Apr 28 2015, 3:40 PM

lpriestley retitled this revision from to Fixing some calendar event timeline issues..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7953: Give calendar events names.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2015, 3:40 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

lpriestley added inline comments.Apr 28 2015, 3:42 PM

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
82	maybe should be just a "else" not "else if"?

Minor edit. Changing if/else.

epriestley accepted this revision.Apr 28 2015, 3:54 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 28 2015, 3:54 PM

Closed by commit rPd816ac0b01d7: Fixing some calendar event timeline issues. (authored by lpriestley, committed by lpriestley). · Explain WhyApr 28 2015, 3:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

controller/

PhabricatorCalendarEventViewController.php

4 lines

storage/

PhabricatorCalendarEventTransaction.php

7 lines

Diff 30234

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php