Page MenuHomePhabricator
Differential D12592

Fixing some calendar event timeline issues.
ClosedPublic
Actions

Authored by lpriestley on Apr 28 2015, 3:40 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Sep 25, 6:44 AM
Unknown Object (File)
Tue, Sep 17, 8:08 AM
Unknown Object (File)
Thu, Sep 12, 7:05 AM
Unknown Object (File)
Thu, Sep 12, 7:05 AM
Unknown Object (File)
Sep 5 2024, 12:02 PM
Unknown Object (File)
Sep 1 2024, 11:50 AM
Unknown Object (File)
Aug 31 2024, 9:24 PM
Unknown Object (File)
Aug 26 2024, 8:25 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7953: Give calendar events names
Commits
Restricted Diffusion Commit
rPd816ac0b01d7: Fixing some calendar event timeline issues.
Summary

Ref T7953, Fixing some calendar event timeline issues.

Test Plan

Create event, event timeline should reflect the transaction.

Diff Detail

Repository
rP Phabricator
Branch
calendareventnames2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5562
Build 5581: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30232.Apr 28 2015, 3:40 PM
lpriestley retitled this revision from to Fixing some calendar event timeline issues..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7953: Give calendar events names.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 28 2015, 3:40 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley added inline comments.Apr 28 2015, 3:42 PM
src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php
82

maybe should be just a "else" not "else if"?

lpriestley updated this revision to Diff 30233.Apr 28 2015, 3:53 PM
lpriestley edited edge metadata.

Minor edit. Changing if/else.

lpriestley marked an inline comment as done.Apr 28 2015, 3:53 PM
epriestley accepted this revision.Apr 28 2015, 3:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 28 2015, 3:54 PM
Closed by commit rPd816ac0b01d7: Fixing some calendar event timeline issues. (authored by lpriestley, committed by lpriestley). · Explain WhyApr 28 2015, 3:56 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
controller/
4 lines
storage/
7 lines

Diff 30232

View Options

src/applications/calendar/controller/PhabricatorCalendarEventViewController.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEventTransaction.php

Loading...
Phabricator · Built by Phacility