Paths

Table of Contentst

Differential D12590

Improve handling of bad branches in Diffusion
ClosedPublic
Actions

Authored by epriestley on Apr 28 2015, 3:03 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work)

Commits

Restricted Diffusion Commit
rPced20d48eac2: Improve handling of bad branches in Diffusion

Summary

Fixes T7972.

Trap the RefNotFound error which may occur in getAlternatives().
Improve error handling in Mercurial.

Test Plan

Screen Shot 2015-04-28 at 8.01.03 AM.png (1×1 px, 168 KB)

Diff Detail

Repository

rP Phabricator

Branch

badref

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5560
Build 5579: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30229.Apr 28 2015, 3:03 PM

epriestley retitled this revision from to Improve handling of bad branches in Diffusion.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added a task: T7972: Starting with 7f43cde, DiffusionRequest resolveRefs fails (only cached entries work).

Herald added a subscriber: epriestley. · View Herald TranscriptApr 28 2015, 3:03 PM

btrahan accepted this revision.Apr 28 2015, 3:30 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 28 2015, 3:30 PM

Closed by commit rPced20d48eac2: Improve handling of bad branches in Diffusion (authored by epriestley, committed by epriestley). · Explain WhyApr 28 2015, 3:56 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

diffusion/

query/

lowlevel/

DiffusionLowLevelResolveRefsQuery.php

4 lines

request/

DiffusionRequest.php

7 lines

Diff 30229

View Options

src/applications/diffusion/query/lowlevel/DiffusionLowLevelResolveRefsQuery.php