Paths

Table of Contentst

Differential D12581

Calendar event monograms, part 4. Typing E{id} makes the object available in global search.
ClosedPublic
Actions

Authored by lpriestley on Apr 27 2015, 10:19 PM.

Tags

None

Referenced Files

	F15462304: D12581.id.diff
	Tue, Apr 1, 1:50 PM

	F15459048: D12581.id30206.diff
	Mon, Mar 31, 9:22 AM

	F15450777: D12581.id30206.diff
	Fri, Mar 28, 6:12 PM

	F15450110: D12581.id.diff
	Fri, Mar 28, 2:02 PM

	F15448260: D12581.id30207.diff
	Fri, Mar 28, 3:46 AM

	F15444057: D12581.diff
	Thu, Mar 27, 7:34 AM

	F15435098: D12581.id30207.diff
	Tue, Mar 25, 6:47 AM

	F15431195: D12581.diff
	Mon, Mar 24, 11:04 AM

Subscribers

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7928: Give Calendar events the "E" Monogram

Commits

Restricted Diffusion Commit
rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in…

Summary

Closes T7928, E{id} is available via global search.

Test Plan

Create calendar event, search for its monogram in global search, event should be accessible.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

lpriestley updated this revision to Diff 30206.Apr 27 2015, 10:19 PM

lpriestley retitled this revision from to T7928, Typing E{id} makes the object available in global search..

lpriestley updated this object.

lpriestley edited the test plan for this revision. (Show Details)

lpriestley added a reviewer: epriestley.

lpriestley added a task: T7928: Give Calendar events the "E" Monogram.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 27 2015, 10:19 PM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

lpriestley retitled this revision from T7928, Typing E{id} makes the object available in global search. to Calendar event monograms, part 4. Typing E{id} makes the object available in global search..Apr 27 2015, 10:20 PM

lpriestley edited edge metadata.

One minor thing.

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
42	I think that has an extra `\d` in it, it should just be like this I think: - '/^E\d[1-9]\d$/i' + '/^E[1-9]\d$/i' If that was a copy/paste, the source is probably messed up too.

This revision now requires changes to proceed.Apr 27 2015, 10:23 PM

Removing extra d from regex.

epriestley accepted this revision.Apr 27 2015, 10:29 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 10:29 PM

Closed by commit rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in… (authored by lpriestley, committed by lpriestley). · Explain WhyApr 27 2015, 10:31 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

calendar/

phid/

PhabricatorCalendarEventPHIDType.php

28 lines

differential/

phid/

DifferentialRevisionPHIDType.php

2 lines

Diff 30208

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

Loading...

src/applications/differential/phid/DifferentialRevisionPHIDType.php

Loading...