Page MenuHomePhabricator
Differential D12581

Calendar event monograms, part 4. Typing E{id} makes the object available in global search.
ClosedPublic
Actions

Authored by lpriestley on Apr 27 2015, 10:19 PM.
Tags
None
Referenced Files
F14054163: D12581.diff
Fri, Nov 15, 10:53 PM
F14042643: D12581.diff
Tue, Nov 12, 5:08 AM
F14028658: D12581.diff
Fri, Nov 8, 3:05 PM
F14006372: D12581.id30206.diff
Mon, Oct 28, 7:49 AM
F14003004: D12581.id30206.diff
Sat, Oct 26, 12:59 AM
F13989530: D12581.id30207.diff
Mon, Oct 21, 9:12 PM
F13988433: D12581.id.diff
Mon, Oct 21, 3:02 PM
F13979488: D12581.diff
Oct 19 2024, 4:52 AM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7928: Give Calendar events the "E" Monogram
Commits
Restricted Diffusion Commit
rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in…
Summary

Closes T7928, E{id} is available via global search.

Test Plan

Create calendar event, search for its monogram in global search, event should be accessible.

Diff Detail

Repository
rP Phabricator
Branch
calendareventmonogrampart4
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5546
Build 5565: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30206.Apr 27 2015, 10:19 PM
lpriestley retitled this revision from to T7928, Typing E{id} makes the object available in global search..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7928: Give Calendar events the "E" Monogram.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 27 2015, 10:19 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
lpriestley retitled this revision from T7928, Typing E{id} makes the object available in global search. to Calendar event monograms, part 4. Typing E{id} makes the object available in global search..Apr 27 2015, 10:20 PM
lpriestley edited edge metadata.
epriestley requested changes to this revision.Apr 27 2015, 10:23 PM
epriestley edited edge metadata.

One minor thing.

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php
42

I think that has an extra \d* in it, it should just be like this I think:

- '/^E\d*[1-9]\d*$/i'
+ '/^E[1-9]\d*$/i'

If that was a copy/paste, the source is probably messed up too.

This revision now requires changes to proceed.Apr 27 2015, 10:23 PM
lpriestley updated this revision to Diff 30207.Apr 27 2015, 10:28 PM
lpriestley edited edge metadata.

Removing extra d from regex.

lpriestley marked an inline comment as done.Apr 27 2015, 10:29 PM
epriestley accepted this revision.Apr 27 2015, 10:29 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 27 2015, 10:29 PM
Closed by commit rP3b226e8fb330: Calendar event monograms, part 4. Typing E{id} makes the object available in… (authored by lpriestley, committed by lpriestley). · Explain WhyApr 27 2015, 10:31 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
phid/
28 lines

Diff 30206

View Options

src/applications/calendar/phid/PhabricatorCalendarEventPHIDType.php

Loading...
Phabricator · Built by Phacility