Page MenuHomePhabricator
Differential D12578

Calendar event monograms, part 1. Event default URL should be install/E{id} instead of install/calendar/view/{id}
ClosedPublic
Actions

Authored by lpriestley on Apr 27 2015, 5:38 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 17, 8:49 PM
Unknown Object (File)
Fri, Jan 17, 10:40 AM
Unknown Object (File)
Tue, Jan 14, 7:06 PM
Unknown Object (File)
Thu, Jan 9, 7:49 AM
Unknown Object (File)
Thu, Jan 2, 4:29 AM
Unknown Object (File)
Fri, Dec 27, 9:41 PM
Unknown Object (File)
Sun, Dec 22, 1:36 AM
Unknown Object (File)
Dec 17 2024, 3:56 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7928: Give Calendar events the "E" Monogram
Commits
Restricted Diffusion Commit
rP7a9c1ea0b4ff: Calendar event monograms, part 1. Event default URL should be install/E{id}…
Summary

Ref T7928, Calendar event monograms, part 1. Default event URL should be install/E{id}

Test Plan

Create calendar event, event should open with install/E{id} URL. Edit event and cancel edit, URL should remain install/E{id}.

Diff Detail

Repository
rP Phabricator
Branch
calendareventmonogram
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5541
Build 5560: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30197.Apr 27 2015, 5:38 PM
lpriestley retitled this revision from to Calendar event monograms, part 1. Event default URL should be install/E{id} instead of install/calendar/view/{id}.
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7928: Give Calendar events the "E" Monogram.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 27 2015, 5:38 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.EditedApr 27 2015, 5:45 PM
epriestley edited edge metadata.

To land this, switch to the calendareventmonogram branch and run:

$ arc land

And it should take care of the rest.

This revision is now accepted and ready to land.Apr 27 2015, 5:45 PM
Closed by commit rP7a9c1ea0b4ff: Calendar event monograms, part 1. Event default URL should be install/E{id}… (authored by lpriestley, committed by lpriestley). · Explain WhyApr 27 2015, 9:26 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
calendar/
application/
3 lines
controller/
3 lines
view/
phui/
calendar/
2 lines

Diff 30197

View Options

src/applications/calendar/application/PhabricatorCalendarApplication.php

Loading...
View Options

src/applications/calendar/controller/PhabricatorCalendarEventEditController.php

Loading...
View Options

src/view/phui/calendar/PHUICalendarListView.php

Loading...
Phabricator · Built by Phacility