Improve messaging around repository locks
ClosedPublic
Actions

Authored by epriestley on Apr 27 2015, 2:22 PM.

Details

Reviewers

Maniphest Tasks

T6958: Make cause/resolution for PhutilLockException during repository import more clear
T7484: Lock is not locked by this process

Commits

Restricted Diffusion Commit
rPfad75f939de5: Improve messaging around repository locks

Summary

Fixes T6958. Ref T7484.

When we collide on a lock in bin/repository update, explain what that means.
GlobalLock currently uses a "lock name" which is different from the lock's actual name. Don't do this. There's a small chance this fixes T7484, but I don't have high hopes.

Test Plan

Ran bin/repository update X in two windows really fast, got the new message in one of them.

Diff Detail

Repository

rP Phabricator

Branch

lock1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5536
Build 5555: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30187.Apr 27 2015, 2:22 PM

epriestley retitled this revision from to Improve messaging around repository locks.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

epriestley added tasks: T7484: Lock is not locked by this process, T6958: Make cause/resolution for PhutilLockException during repository import more clear.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 27 2015, 2:22 PM

btrahan accepted this revision.Apr 27 2015, 5:18 PM

btrahan edited edge metadata.

This revision is now accepted and ready to land.Apr 27 2015, 5:18 PM

I tried to review this from mobile earlier in the AM, but I couldn't seem to navigate the symbol PhutilLock (which I needed to check out to make sure this getName() stuff was kosher).

I think I just have large, clumsy thumbs, but just tossing it out there.

There's some weird code with symbols because we try to wait for a second and see if you're double clicking to select. I'll file an issue, pretty sure it's a real bug related to that. Fix is probably to be smarter about 'touch' events always meaning 'click the symbol'.

epriestley mentioned this in T7960: Jumping to symbols from Differential doesn't work well on mobile.Apr 27 2015, 5:22 PM

Closed by commit rPfad75f939de5: Improve messaging around repository locks (authored by epriestley, committed by epriestley). · Explain WhyApr 27 2015, 5:25 PM

This revision was automatically updated to reflect the committed changes.

epriestley mentioned this in T7484: Lock is not locked by this process.May 25 2015, 2:29 PM

popozhu added a subscriber: popozhu.Aug 18 2015, 1:56 AM