Page MenuHomePhabricator
Differential D12557

New diffusion repository rejection should not navigate away from diffusion.
ClosedPublic
Actions

Authored by lpriestley on Apr 26 2015, 6:58 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 29, 5:30 PM
Unknown Object (File)
Tue, Jan 28, 3:09 AM
Unknown Object (File)
Fri, Jan 24, 10:27 AM
Unknown Object (File)
Fri, Jan 24, 3:10 AM
Unknown Object (File)
Fri, Jan 24, 3:10 AM
Unknown Object (File)
Fri, Jan 24, 3:10 AM
Unknown Object (File)
Fri, Jan 24, 3:10 AM
Unknown Object (File)
Dec 31 2024, 8:26 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T7507: Should return to previous page after clicking "OK"
Commits
Restricted Diffusion Commit
rPe39c3ef82502: New diffusion repository rejection should not navigate away from diffusion.
Summary

Fixes T7507, Create diffusion repo rejection should not navigate away from diffusion.

Test Plan

Login as non-admin, open diffusion, attempt to create new repo, rejection dialog should appear over page instead of navigating to new page.

Diff Detail

Repository
rP Phabricator
Branch
newreporejectionworkflow
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5513
Build 5532: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

lpriestley updated this revision to Diff 30143.Apr 26 2015, 6:58 PM
lpriestley retitled this revision from to New diffusion repository rejection should not navigate away from diffusion..
lpriestley updated this object.
lpriestley edited the test plan for this revision. (Show Details)
lpriestley added a reviewer: epriestley.
lpriestley added a task: T7507: Should return to previous page after clicking "OK".
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 26 2015, 6:58 PM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 26 2015, 7:00 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 26 2015, 7:00 PM
Closed by commit rPe39c3ef82502: New diffusion repository rejection should not navigate away from diffusion. (authored by lpriestley, committed by epriestley). · Explain WhyApr 26 2015, 7:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
diffusion/
controller/
1 line

Diff 30143

View Options

src/applications/diffusion/controller/DiffusionRepositoryListController.php

Loading...
Phabricator · Built by Phacility