Page MenuHomePhabricator

Improve low-level branch resolution in Mercurial
ClosedPublic

Authored by epriestley on Apr 25 2015, 3:52 PM.
Tags
None
Referenced Files
F13211580: D12548.diff
Fri, May 17, 5:54 AM
F13196787: D12548.diff
Sun, May 12, 11:34 PM
F13193561: D12548.diff
Sun, May 12, 3:07 PM
F13190993: D12548.id30132.diff
Sat, May 11, 4:19 PM
Unknown Object (File)
Fri, May 3, 7:14 AM
Unknown Object (File)
Thu, Apr 25, 1:26 AM
Unknown Object (File)
Sat, Apr 20, 12:16 PM
Unknown Object (File)
Sat, Apr 20, 12:16 PM
Subscribers

Details

Summary

Ref T7100. Ref T7108. Ref T6160. Several issues:

  • High load for mercurial repositories with huge numbers of branches (T7108).
    • In Mercurial, we resolve refs individually (one hg call per ref).
    • Each repository update also updates all refs, which requires resolving all of them.
    • For repositories with a huge number of branches,
  • We don't distinguish between closed branches (a Mercurial-only concept) and open branches (T6160).
    • In Git, when a branch is merged, it ceases to exist.
    • In Mercurial, when a branch is merged, it still exists, it's just "closed". Normally, no one cares about these branches.
    • In the low-level query, correctly identify which refs we resolve as branches.
    • In the low-level query, correctly mark closed branches as closed.
  • This marginally improves ref handling in general (see T7100).
Test Plan

Screen_Shot_2015-04-25_at_8.51.45_AM.png (144×791 px, 37 KB)

Screen_Shot_2015-04-25_at_8.51.22_AM.png (759×1 px, 137 KB)

Diff Detail

Repository
rP Phabricator
Branch
repo2
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5504
Build 5523: [Placeholder Plan] Wait for 30 Seconds