Differential D12518

Memoize PHP compatibility info
ClosedPublic
Actions

Authored by joshuaspence on Apr 23 2015, 1:29 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Sep 7, 1:06 PM

	Unknown Object (File)
	Fri, Aug 30, 9:51 PM

	Unknown Object (File)
	Wed, Aug 28, 6:31 AM

	Unknown Object (File)
	Sun, Aug 25, 7:32 AM

	Unknown Object (File)
	Aug 14 2024, 11:03 AM

	Unknown Object (File)
	Aug 6 2024, 11:11 AM

	Unknown Object (File)
	Jul 13 2024, 1:19 PM

	Unknown Object (File)
	Jul 6 2024, 10:49 AM

Subscribers

Tokens

"Piece of Eight" token, awarded by epriestley.

Details

Reviewers

Group Reviewers

Blessed Reviewers

Maniphest Tasks

T7892: Investigate lint performance issues

Commits

rARCd6f4bded25ee: Memoize PHP compatibility info

Summary

Ref T7892. Avoid reading the PHP compatibility information for every file being linted.

Test Plan

Before

real    1m24.327s
user    1m19.571s
sys 0m5.239s

real    1m12.029s
user    1m5.756s
sys 0m5.502s

Diff Detail

Repository

Branch

master

Lint

Lint Passed

Unit

Test Failures

Build Status

Buildable 5456
Build 5474: [Placeholder Plan] Wait for 30 Seconds

Unit TestsFailed
View All

	Time	Test
	1,210 ms	ArcanistPuppetLintLinterTestCase::testLinter
	816 ms	ArcanistCSSLintLinterTestCase::testLinter
	173 ms	ArcanistCSSLintLinterTestCase::testVersion
	138 ms	ArcanistChmodLinterTestCase::testLinter
	246 ms	ArcanistClosureLinterTestCase::testLinter
		View Full Test Results (1 Failed · 48 Passed · 4 Skipped)

Event Timeline

joshuaspence updated this revision to Diff 30057.Apr 23 2015, 1:29 AM

joshuaspence retitled this revision from to Memoize PHP compatibility info.

joshuaspence updated this object.

joshuaspence edited the test plan for this revision. (Show Details)

joshuaspence added a reviewer: epriestley.

joshuaspence added a task: T7892: Investigate lint performance issues.

Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 23 2015, 1:29 AM

Herald added subscribers: epriestley, Korvin. · View Herald Transcript

epriestley accepted this revision.Apr 23 2015, 1:30 AM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 23 2015, 1:30 AM

epriestley awarded a token.Apr 23 2015, 1:31 AM

Closed by commit rARCd6f4bded25ee: Memoize PHP compatibility info (authored by joshuaspence, committed by joshuaspence). · Explain WhyApr 23 2015, 10:19 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

10 lines

Diff 30057

src/lint/linter/ArcanistXHPASTLinter.php

Loading...