Fix a possible undefined variable
ClosedPublic
Actions

Authored by epriestley on Apr 22 2015, 2:26 AM.

Details

Reviewers

joshuaspence
btrahan

Maniphest Tasks

T7881: Undefined variable when viewing diff

Commits

Restricted Diffusion Commit
rP4dea152215cc: Fix a possible undefined variable

Summary

Fixes T7881.

Test Plan

Inspection.

Diff Detail

Repository

rP Phabricator

Branch

uvar1

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5430
Build 5448: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 30013.Apr 22 2015, 2:26 AM

epriestley retitled this revision from to Fix a possible undefined variable.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

epriestley added a task: T7881: Undefined variable when viewing diff.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 22 2015, 2:26 AM

joshuaspence accepted this revision.Apr 22 2015, 2:27 AM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Apr 22 2015, 2:27 AM

Don't we have a linter rule for this?

It doesn't (and generally can't) do flow analysis, so it assumes things are in good shape after the declaration on 180.

Closed by commit rP4dea152215cc: Fix a possible undefined variable (authored by epriestley, committed by epriestley). · Explain WhyApr 22 2015, 2:28 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

controller/

DifferentialChangesetViewController.php

1 line

Diff 30013

View Options

src/applications/differential/controller/DifferentialChangesetViewController.php

Fix a possible undefined variableClosedPublicActions