Page MenuHomePhabricator
Differential D12481

Move setup warning callout above the nav-drag div
ClosedPublic
Actions

Authored by mattrobenolt on Apr 20 2015, 5:51 PM.
Tags
None
Referenced Files
F18977947: D12481.diff
Sun, Nov 16, 7:04 PM
F18840257: D12481.id.diff
Mon, Oct 27, 10:51 PM
F18835059: D12481.diff
Sun, Oct 26, 12:56 PM
F18828130: D12481.id29964.diff
Fri, Oct 24, 2:29 PM
F18812628: D12481.id29963.diff
Mon, Oct 20, 10:53 AM
F18811383: D12481.diff
Mon, Oct 20, 3:04 AM
F18777074: D12481.id29964.diff
Oct 11 2025, 12:49 AM
F18770207: D12481.diff
Oct 8 2025, 11:22 AM
View All Files
Subscribers
epriestley
Korvin
Tokens
"The World Burns" token, awarded by chad.

Details

Reviewers
epriestley
chad
Group Reviewers
Blessed Reviewers
Commits
Restricted Diffusion Commit
rP6193548b4683: Move setup warning callout above the nav-drag div
Required Signatures
L28 Phacility Individual Contributor License Agreement
Summary

See T7830: Differential highlighting highlights wrong lines when setup warning is ignored by lackadaisical admins

Test Plan

I manually set this to 5 in Chrome inspector and checked a few pages.

Diff Detail

Repository
rP Phabricator
Branch
header
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5403
Build 5421: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

mattrobenolt updated this revision to Diff 29963.Apr 20 2015, 5:51 PM
mattrobenolt retitled this revision from to Move setup warning callout above the nav-drag div.
mattrobenolt updated this object.
mattrobenolt edited the test plan for this revision. (Show Details)
mattrobenolt added reviewers: chad, epriestley.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptApr 20 2015, 5:51 PM
Herald added a required legal document: L28 Phacility Individual Contributor License Agreement. · View Herald Transcript
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
epriestley accepted this revision.Apr 20 2015, 5:52 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 20 2015, 5:52 PM
Closed by commit rP6193548b4683: Move setup warning callout above the nav-drag div (authored by mattrobenolt, committed by epriestley). · Explain WhyApr 20 2015, 5:53 PM
This revision was automatically updated to reflect the committed changes.
epriestley added a comment.Apr 20 2015, 5:53 PM

Thanks!

chad awarded a token.Apr 20 2015, 5:57 PM

Revision Contents
Changeset List

PathSize
webroot/
rsrc/
css/
core/
5 lines

Diff 29963

View Options

webroot/rsrc/css/core/z-index.css

Loading...
Phabricator · Built by Phacility