Paths

Table of Contentst

Differential D12477

Fix an issue with custom policy edit control not populating correctly
ClosedPublic
Actions

Authored by epriestley on Apr 20 2015, 2:57 PM.

Tags

None

Referenced Files

	F13171489: D12477.diff
	Tue, May 7, 10:55 AM

	F13170679: D12477.diff
	Tue, May 7, 9:36 AM

	Unknown Object (File)
	Apr 3 2024, 12:29 AM

	Unknown Object (File)
	Mar 20 2024, 11:38 PM

	Unknown Object (File)
	Mar 17 2024, 5:19 PM

	Unknown Object (File)
	Mar 13 2024, 5:23 PM

	Unknown Object (File)
	Mar 9 2024, 5:01 PM

	Unknown Object (File)
	Mar 6 2024, 4:05 AM

Subscribers

Details

Reviewers

btrahan
chad

Maniphest Tasks

T7866: Diffusion repository with custom policies do not load the custom policies when modifying

Commits

Restricted Diffusion Commit
rP2875f029be7f: Fix an issue with custom policy edit control not populating correctly

Summary

Fixes T7866. These values aren't always provided. They should be, but just make things work for now.

Test Plan

Edited a task.
Selected "Custom Policy" for "Edit Policy".
Configured a policy like "Users: dog".
Saved policy.
Selected "Custom Policy" again to edit the policy.
Before patch: tokenizer fails to render with an error (config.types is not an object).
After patch: tokenizer renders properly, albeit with a missing icon.

Diff Detail

Repository

Branch

policyedit

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5397
Build 5415: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

epriestley updated this revision to Diff 29938.Apr 20 2015, 2:57 PM

epriestley retitled this revision from to Fix an issue with custom policy edit control not populating correctly.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptApr 20 2015, 2:57 PM

chad accepted this revision.Apr 20 2015, 3:12 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Apr 20 2015, 3:12 PM

Closed by commit rP2875f029be7f: Fix an issue with custom policy edit control not populating correctly (authored by epriestley, committed by epriestley). · Explain WhyApr 20 2015, 3:16 PM

This revision was automatically updated to reflect the committed changes.

epriestley added a task: T7866: Diffusion repository with custom policies do not load the custom policies when modifying.Apr 20 2015, 3:16 PM

epriestley updated this object.

epriestley edited edge metadata.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

30 lines

webroot/

rsrc/

js/

core/

6 lines

Diff 29938

resources/celerity/map.php

Loading...

webroot/rsrc/js/core/Prefab.js

Loading...