Moves the Browse... button into a Search Icon on the actual tokenizer. I played with a number of icon treatments, and Search seems to convey the right attribute, other things like lists and menus didn't quite feel right to me, but feel free to push back if you hate search.
Details
Details
- Reviewers
epriestley btrahan - Maniphest Tasks
- T7841: Improve the design of the tokenizer browse control
- Commits
- Restricted Diffusion Commit
rPca388d95fd16: Make the browse button on the tokenizer, be on the tokenizer
Tested lots of tokens, little tokens, small screens, etc.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- browse-button
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 5361 Build 5379: [Placeholder Plan] Wait for 30 Seconds
Event Timeline
Comment Actions
If you didn't check them, two other weird test cases are:
- Maniphest -> Add Subscribers (shouldn't have browse right now, but should work fine).
- Herald, Maniphest Batch Edit, Edit Policy -> Custom Policy: should have browse and should work (all three of these will probably work fine if any one of them works fine).
Comment Actions
uh, no, those cases don't work... Add CCs now has a button when it didn't previously, the Batch Editor UI is wonky, but I can probably fix that with some CSS.
Comment Actions
There's some stuff in tokenizer.css which should probably get cleaned up, too.
Roughly, the idea with the has-browse class is:
- The button is always rendered into the DOM, just invisible by default.
- If a control is browsable, we add has-browse: CSS should then reveal the button.
Comment Actions
Specifically, some/all of these rules are probably junk now:
.jx-tokenizer-frame { width: 100%; } .jx-tokenizer-frame .jx-tokenizer-frame-browse { display: none; } .has-browse .jx-tokenizer-frame-browse { display: table-cell; } .jx-tokenizer-frame td.jx-tokenizer-frame-input { width: 100%; } .jx-tokenizer-frame-browse { width: 100px; vertical-align: middle; padding: 0 0 0 4px; }
Comment Actions
(The unusual way the rendering works is because in Herald we produce a single "template" that needs to be able to generate both browsable and unbrowsable typehaeads, so we always have to be able to have a button to show.)