Page MenuHomePhabricator

Conpherence - fix policy bug on comments with files in rooms
ClosedPublic

Authored by btrahan on Apr 16 2015, 11:13 PM.
Tags
None
Referenced Files
F14408222: D12443.diff
Tue, Dec 24, 4:16 AM
Unknown Object (File)
Wed, Nov 27, 11:36 PM
Unknown Object (File)
Nov 20 2024, 8:25 AM
Unknown Object (File)
Nov 10 2024, 4:38 PM
Unknown Object (File)
Nov 10 2024, 6:46 AM
Unknown Object (File)
Nov 6 2024, 5:00 AM
Unknown Object (File)
Oct 22 2024, 11:35 PM
Unknown Object (File)
Oct 22 2024, 3:25 PM
Subscribers

Details

Summary

Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan

arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Diff Detail

Repository
rP Phabricator
Branch
T7840
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5345
Build 5363: [Placeholder Plan] Wait for 30 Seconds