Page MenuHomePhabricator

Conpherence - fix policy bug on comments with files in rooms
ClosedPublic

Authored by btrahan on Apr 16 2015, 11:13 PM.
Tags
None
Referenced Files
Unknown Object (File)
Feb 1 2025, 10:47 PM
Unknown Object (File)
Jan 30 2025, 2:34 PM
Unknown Object (File)
Jan 29 2025, 3:25 AM
Unknown Object (File)
Jan 23 2025, 12:38 PM
Unknown Object (File)
Jan 21 2025, 10:33 AM
Unknown Object (File)
Jan 13 2025, 7:47 AM
Unknown Object (File)
Jan 12 2025, 4:25 PM
Unknown Object (File)
Dec 24 2024, 8:23 AM
Subscribers

Details

Summary

Fixes T7840. Add some unit tests. One explicitly covers the case in T7840. Other cases are "base" cases for rooms and threads, plus the version if T7840 for a thread, where a policy exception should be thrown.

Test Plan

arc unit and was able to successfully add a file to a conpherence room i did not have edit permissions on

Diff Detail

Repository
rP Phabricator
Branch
T7840
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5345
Build 5363: [Placeholder Plan] Wait for 30 Seconds