Page MenuHomePhabricator
Differential D12430

Use white for active state on mobile menus
ClosedPublic
Actions

Authored by chad on Apr 15 2015, 10:31 PM.
Tags
None
Referenced Files
F13175676: D12430.diff
Wed, May 8, 6:39 AM
Unknown Object (File)
Tue, May 7, 7:49 AM
Unknown Object (File)
Fri, May 3, 7:28 AM
Unknown Object (File)
Thu, Apr 25, 1:34 AM
Unknown Object (File)
Thu, Apr 11, 9:09 AM
Unknown Object (File)
Mar 31 2024, 9:21 AM
Unknown Object (File)
Mar 8 2024, 6:08 AM
Unknown Object (File)
Feb 27 2024, 8:02 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
epriestley
btrahan
Commits
Restricted Diffusion Commit
rP9796515b7061: Use white for active state on mobile menus
Summary

Perviously we used {$sky} but we've since change the icons to .8 opacity on white, allowing use of white on select.

Test Plan

Click on the mobile menu, see icon turn white instead of blue.

Diff Detail

Repository
rP Phabricator
Branch
mobile-menu
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5331
Build 5349: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29839.Apr 15 2015, 10:31 PM
chad retitled this revision from to Use white for active state on mobile menus.
chad updated this object.
chad edited the test plan for this revision. (Show Details)
chad added reviewers: epriestley, btrahan.
Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 15 2015, 10:31 PM
epriestley accepted this revision.Apr 15 2015, 10:41 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.Apr 15 2015, 10:41 PM
Closed by commit rP9796515b7061: Use white for active state on mobile menus (authored by chad, committed by chad). · Explain WhyApr 15 2015, 11:04 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
view/
page/
menu/
4 lines

Diff 29839

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Loading...
Phabricator · Built by Phacility