Use white for active state on mobile menus
ClosedPublic
Actions

Authored by chad on Apr 15 2015, 10:31 PM.

Tags

None

Referenced Files

	F14059595: D12430.diff
	Sun, Nov 17, 8:38 PM

	F14050808: D12430.diff
	Thu, Nov 14, 8:48 PM

	F14048337: D12430.id29839.diff
	Thu, Nov 14, 7:32 AM

	F14041860: D12430.diff
	Mon, Nov 11, 10:14 PM

	F14037109: D12430.diff
	Sun, Nov 10, 1:54 PM

	F14029718: D12430.id29839.diff
	Fri, Nov 8, 8:59 PM

	F14027330: D12430.id29839.diff
	Fri, Nov 8, 6:35 AM

	F14021964: D12430.diff
	Wed, Nov 6, 2:11 PM

View All Files

Subscribers

epriestley

Korvin

Details

Reviewers

epriestley
btrahan

Commits

Restricted Diffusion Commit
rP9796515b7061: Use white for active state on mobile menus

Summary

Perviously we used {$sky} but we've since change the icons to .8 opacity on white, allowing use of white on select.

Test Plan

Click on the mobile menu, see icon turn white instead of blue.

Diff Detail

Repository

rP Phabricator

Branch

mobile-menu

Lint

Lint Passed

Unit

Tests Passed

Build Status

Buildable 5331
Build 5349: [Placeholder Plan] Wait for 30 Seconds

Event Timeline

chad updated this revision to Diff 29839.Apr 15 2015, 10:31 PM

chad retitled this revision from to Use white for active state on mobile menus.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptApr 15 2015, 10:31 PM

epriestley accepted this revision.Apr 15 2015, 10:41 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Apr 15 2015, 10:41 PM

Closed by commit rP9796515b7061: Use white for active state on mobile menus (authored by chad, committed by chad). · Explain WhyApr 15 2015, 11:04 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

view/

page/

menu/

PhabricatorMainMenuView.php

4 lines

Diff 29839

View Options

src/view/page/menu/PhabricatorMainMenuView.php

Use white for active state on mobile menusClosedPublicActions