Page MenuHomePhabricator

Add a linter rule for incorrect use of parent scope
ClosedPublic

Authored by joshuaspence on Apr 15 2015, 10:56 AM.
Tags
None
Referenced Files
F15416001: D12420.id30873.diff
Thu, Mar 20, 8:37 AM
F15399077: D12420.id.diff
Mon, Mar 17, 2:46 AM
F15395938: D12420.diff
Sun, Mar 16, 10:50 AM
F15393506: D12420.id30873.diff
Sat, Mar 15, 9:07 PM
F15377358: D12420.id30873.diff
Thu, Mar 13, 8:41 AM
F15359498: D12420.diff
Tue, Mar 11, 7:48 AM
F15353109: D12420.diff
Mon, Mar 10, 8:04 PM
F15341191: D12420.id30873.diff
Sun, Mar 9, 7:01 PM
Subscribers

Details

Summary

The following code is invalid:

final class MyClass {
  public function __construct() {
    parent::__construct(null);
  }
}

$x = new MyClass();

Running the above code will produce a fatal error:

PHP Fatal error:  Cannot access parent:: when current class scope has no parent
Test Plan

Added unit tests.

Diff Detail

Repository
rARC Arcanist
Branch
master
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 5320
Build 5338: [Placeholder Plan] Wait for 30 Seconds